tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
Date Mon, 12 Apr 2010 18:59:16 GMT
On 12/04/2010, Mark Thomas <markt@apache.org> wrote:
> On 12/04/2010 11:53, Tim Funk wrote:
>  > This seems like an odd thing to make a constant. (Is something else
>  > setting this or was there an intention for this to be set? Especially
>  > since it is used only once in this file)
>
>
> It isn't entirely clear. I suspect it was going to be made configurable
>  at start-up at some point. The naming convention implies constant. If it
>  is ever made configurable, the final can be removed if required.

This was done to fix:

https://issues.apache.org/bugzilla/show_bug.cgi?id=49089

If it is ever made mutable, please consider making it a private
instance variable instead of a thread-hostile mutable static.

>  Mark
>
>
>  >
>  > -Tim
>  >
>  > On 4/12/2010 5:35 AM, markt@apache.org wrote:
>  >> Author: markt
>  >> Date: Mon Apr 12 09:35:52 2010
>  >> New Revision: 933165
>  >>
>  >> URL: http://svn.apache.org/viewvc?rev=933165&view=rev
>  >> Log:
>  >> Make public constant final
>  >>
>  >> Modified:
>  >>      tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>  >>
>  >> Modified:
>  >> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>  >> URL:
>  >> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java?rev=933165&r1=933164&r2=933165&view=diff
>  >>
>  >> ==============================================================================
>  >>
>  >> --- tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>  >> (original)
>  >> +++ tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>  >> Mon Apr 12 09:35:52 2010
>  >> @@ -38,7 +38,7 @@ import java.sql.Timestamp;
>  >>   public class ChannelData implements ChannelMessage {
>  >>       public static final ChannelData[] EMPTY_DATA_ARRAY = new
>  >> ChannelData[0];
>  >>
>  >> -    public static boolean USE_SECURE_RANDOM_FOR_UUID = false;
>  >> +    public static final boolean USE_SECURE_RANDOM_FOR_UUID = false;
>  >>
>  >>       /**
>  >>        * The options this message was sent with
>  >
>  > ---------------------------------------------------------------------
>  > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>  > For additional commands, e-mail: dev-help@tomcat.apache.org
>  >
>
>
>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>  For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message