tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 49101] New: All constants in tribes.transport.Constants are mutable
Date Mon, 12 Apr 2010 20:01:12 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=49101

           Summary: All constants in tribes.transport.Constants are
                    mutable
           Product: Tomcat 7
           Version: trunk
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: sebb@apache.org


The "constant" fields in tribes.transport.Constants are defined as non-empty
public static final byte arrays, so are not actually immutable.

The _DATA fields only appear to be used in Arrays.equals method calls, so the
array comparison could be moved to the Constants class.

The _COMMAND fields are a bit more difficult to protect, but there could be a
getter that returned a copy of the array.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message