tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Hanik - Dev Lists <devli...@hanik.com>
Subject Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
Date Wed, 14 Apr 2010 13:32:44 GMT
On 04/14/2010 07:07 AM, Konstantin Kolinko wrote:
> 2010/4/13 Filip Hanik - Dev Lists<devlists@hanik.com>:
>    
>> This makes zero sense and I would do a -1 on this commit and the bug in
>> general.
>> What effectively has happened here is that there has been a public API
>> change without any justification.
>>
>> Since this is a mutable field, you've now made it non mutable. and in there
>> lies the change.
>>
>>      
> I am +1 on the change.
>    
doesn't change a veto
> If we need it configurable, let's define a system property to
> initialize its value at startup,
>    
I agree, however that was not done in the original commit.
> or better to define an instance field somewhere.
>    
again, I agree. If you're gonna change the API, do it right. Let's not 
make variables "final" cause it's someone preference
> It makes no sense for me to flip between "secure random" and "insecure
> random" at runtime.
>
> Best regards,
> Konstantin Kolinko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>    


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message