tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject DO NOT REPLY [Bug 49045] JMX Enhancement- Provision of MBeanFactory createStandardService
Date Wed, 07 Apr 2010 11:45:04 GMT

--- Comment #3 from chamith buddhika <> 2010-04-07 11:45:01 UTC
(In reply to comment #2)
Hi Mark,

> You should be targeting your patches at Tomcat 7 aka trunk. Please raise bugs
> against Tomcat 7 too.

I will raise a bug for Tomcat 7 as well.

> The Factory can be associated with a Server or a Service. If it is associated
> with a Service it isn't valid to try adding another Service. That should
> probably throw an Exception.

Here what I was thinking was since technically a Server can contain more than
one service that it would be possible to add another service to the server
associated with the current service component in the MBeanFactory. I will
change it to throw an exception.

> Why are you creating an Engine too? Only a Service should be created. Creating
> an Engine should be a separate method.

Please correct me if I am wrong here. Since one service is always mapped only
to one Engine component it would be not possible to use an existing registered
Engine component with the newly created service without any side effects. Hence
the creation of a brand new engine within the new service. I saw this has been
done in the removed codes using ServerFactory as well. Another option would be
that user can seperately create an Engine component prior to Service creation
and register it and then use it to create the new Service. I will add a
separate method to create an Engine component in that case.

> I haven't looked at this in much detail but I'd be surprised if modifying the
> modeler code is necessary. I'd find a method on a bean that does work (eg the
> addAlias() method on a host) and see if anything is different about the way it
> is set up compared to the MBeanFactory.

I will look in to this further. 


Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message