tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject DO NOT REPLY [Bug 49045] JMX Enhancement- Provision of MBeanFactory createStandardService
Date Tue, 06 Apr 2010 21:32:25 GMT

--- Comment #2 from Mark Thomas <> 2010-04-06 21:32:20 UTC ---
A couple of comments.

You should be targeting your patches at Tomcat 7 aka trunk. Please raise bugs
against Tomcat 7 too.

The Factory can be associated with a Server or a Service. If it is associated
with a Service it isn't valid to try adding another Service. That should
probably throw an Exception.

If the Factory is associated with a Server then casting container to Server
should work.

Why are you creating an Engine too? Only a Service should be created. Creating
an Engine should be a separate method.

I haven't looked at this in much detail but I'd be surprised if modifying the
modeler code is necessary. I'd find a method on a bean that does work (eg the
addAlias() method on a host) and see if anything is different about the way it
is set up compared to the MBeanFactory.

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message