Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
From: bugzilla@apache.org
To: dev@tomcat.apache.org
Subject: DO NOT REPLY [Bug 48791] Race condition in class
 javax.el.BeanELResolver$BeanProperty field read/write
In-Reply-To: <bug-48791-78@https.issues.apache.org/bugzilla/>
References: <bug-48791-78@https.issues.apache.org/bugzilla/>
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Message-Id: <20100302023856.BF147234C4A8@brutus.apache.org>
Date: Tue,  2 Mar 2010 02:38:56 +0000 (UTC)

https://issues.apache.org/bugzilla/show_bug.cgi?id=48791

Yao Qi <qiyaoltc@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |qiyaoltc@gmail.com

--- Comment #2 from Yao Qi <qiyaoltc@gmail.com> 2010-03-02 02:38:55 UTC ---
(In reply to comment #1)
> It might be inefficient (although I doubt you'd notice it in any realistic
> test), it might be poor coding style (that is arguable) but it isn't a bug.
Can you explain a little bit why it isn't a bug?
If two threads access the following code,
255        private Method read(ELContext ctx) {
256            if (this.read == null) {
257              this.read = getMethod(this.owner,descriptor.getReadMethod());

The value of this.read will be either return value of getMethod invoked by two
threads.  Can we change it to this manner,

if (this.read == null) {
      synchronized (lock4Read){
           if (this.read == null){
             this.read = getMethod(this.owner,descriptor.getReadMethod());
           }
      }

This change is still efficient, and make sure no race in it.  How do you think?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org