tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkoli...@apache.org
Subject svn commit: r909877 - /tomcat/tc6.0.x/trunk/STATUS.txt
Date Sat, 13 Feb 2010 19:30:48 GMT
Author: kkolinko
Date: Sat Feb 13 19:30:48 2010
New Revision: 909877

URL: http://svn.apache.org/viewvc?rev=909877&view=rev
Log:
review comment addresses - update vote
not voting for 48616 yet - still reviewing

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=909877&r1=909876&r2=909877&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sat Feb 13 19:30:48 2010
@@ -139,23 +139,8 @@
   http://svn.apache.org/viewvc?view=rev&rev=899918 (Enum coercion test cases)
   http://svn.apache.org/viewvc?view=rev&rev=899919 (Enum coercion bug)
   http://svn.apache.org/viewvc?rev=909875&view=rev (kkolinko's review - toString())
-   +1: markt
-   -1: kkolinko:
-     As far as I am reading, there is no provision in the EL
-     spec, that enum -> enum conversion can be performed by using its
-     string value.
-
-     The current TC 6.0 behaviour here will be a ClassCastException, trying
-     to assign the value, and that should be an ELException instead.
-
-     In EL 2.1 and 2.2 specifications chapter 1.18.6 'Coerce A to an Enum Type T' says:
-       "If A is a String call Enum.valueOf(T.getClass(), A) and return the result."
-     Thus, our
-      result = Enum.valueOf(type, obj.toString());
-     should only be applicable if obj is a String.
-
-     In ELSupport#coerceToType(Object, Class), that implements 1.18.7, we
-     already throw an ELException if A is not a String.
+   +1: markt, kkolinko
+   -1:
 
   http://svn.apache.org/viewvc?view=rev&rev=899935 (ELException expected)
   +1: markt, kkolinko
@@ -202,6 +187,12 @@
   +1: markt
   -1: 
 
+  Additional patches (trivial):
+  http://svn.apache.org/viewvc?rev=905643&view=rev (misprint)
+  http://svn.apache.org/viewvc?rev=909865&view=rev (javadoc)
+  +1: kkolinko
+  -1:
+
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48612
   Prevent exception on shutdown
   Port of r896193 and r905343



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message