Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 90784 invoked from network); 13 Jan 2010 22:06:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 13 Jan 2010 22:06:41 -0000 Received: (qmail 36253 invoked by uid 500); 13 Jan 2010 22:06:40 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 36175 invoked by uid 500); 13 Jan 2010 22:06:40 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 36164 invoked by uid 99); 13 Jan 2010 22:06:39 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jan 2010 22:06:39 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [72.22.94.67] (HELO virtual.halosg.com) (72.22.94.67) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jan 2010 22:06:30 +0000 Received: (qmail 12120 invoked from network); 13 Jan 2010 16:06:09 -0600 Received: from 38-171-19-72.skybeam.com (HELO ?192.168.3.125?) (72.19.171.38) by halosg.com with (DHE-RSA-AES256-SHA encrypted) SMTP; 13 Jan 2010 16:06:09 -0600 Message-ID: <4B4E43CE.8060009@hanik.com> Date: Wed, 13 Jan 2010 15:06:06 -0700 From: Filip Hanik - Dev Lists User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3 MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r898909 - /tomcat/tc6.0.x/trunk/STATUS.txt References: <20100113192616.751E023889B1@eris.apache.org> <427155181001131340k3e5c56fal357d524c38d2832a@mail.gmail.com> In-Reply-To: <427155181001131340k3e5c56fal357d524c38d2832a@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org On 01/13/2010 02:40 PM, Konstantin Kolinko wrote: > 2010/1/13: > >> Author: fhanik >> Date: Wed Jan 13 19:26:16 2010 >> New Revision: 898909 >> >> URL: http://svn.apache.org/viewvc?rev=898909&view=rev >> Log: >> backport of connectivity fix >> >> Modified: >> tomcat/tc6.0.x/trunk/STATUS.txt >> >> > >> + >> +* Force disconnect upon transmission failure >> + http://svn.apache.org/viewvc?rev=898906&view=rev >> + +1: fhanik >> + -1: >> + >> > Just wondering: > > 1. If any destination fails, you will disconnect the whole sender? > yes, I was pondering only disconnecting the faulty members, but decided against it. since its an error condition, better clean everything up. > 2. Shouldn't disconnect() call be surrounded by try{}catch ? > nope, it doesn't throw any exceptions. It itself does a try/catch around the actual closure thanks for the feedback Filip > Best regards, > Konstantin Kolinko > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org > For additional commands, e-mail: dev-help@tomcat.apache.org > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org