Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 19041 invoked from network); 8 Jan 2010 12:32:15 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 8 Jan 2010 12:32:15 -0000 Received: (qmail 6560 invoked by uid 500); 8 Jan 2010 12:32:14 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 6469 invoked by uid 500); 8 Jan 2010 12:32:14 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 6458 invoked by uid 99); 8 Jan 2010 12:32:14 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Jan 2010 12:32:14 +0000 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [193.252.22.159] (HELO smtp5.freeserve.com) (193.252.22.159) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Jan 2010 12:32:04 +0000 Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf3403.me.freeserve.com (SMTP Server) with ESMTP id 952041C000A8 for ; Fri, 8 Jan 2010 13:31:44 +0100 (CET) Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf3403.me.freeserve.com (SMTP Server) with ESMTP id 7F17C1C000AD for ; Fri, 8 Jan 2010 13:31:44 +0100 (CET) Received: from mail.homeinbox.net (unknown [91.109.129.181]) by mwinf3403.me.freeserve.com (SMTP Server) with ESMTP id 4BB541C000A8 for ; Fri, 8 Jan 2010 13:31:44 +0100 (CET) X-ME-UUID: 20100108123144310.4BB541C000A8@mwinf3403.me.freeserve.com Received: from localhost (localhost [127.0.0.1]) by mail.homeinbox.net (Postfix) with ESMTP id ADF7F32625 for ; Fri, 8 Jan 2010 12:32:26 +0000 (GMT) X-Virus-Scanned: Debian amavisd-new at homeinbox.net Received: from mail.homeinbox.net ([127.0.0.1]) by localhost (mail.homeinbox.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PBuH0DkrlKke for ; Fri, 8 Jan 2010 12:32:23 +0000 (GMT) Received: from [192.168.0.9] (router.dev.local [192.168.0.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.homeinbox.net (Postfix) with ESMTPSA id 416C332002 for ; Fri, 8 Jan 2010 12:32:23 +0000 (GMT) Message-ID: <4B472593.5000406@apache.org> Date: Fri, 08 Jan 2010 12:31:15 +0000 From: Mark Thomas User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-GB; rv:1.9.1.5) Gecko/20091204 Thunderbird/3.0 MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: EL issues and 6.0.x release References: <4B4718BF.5000208@apache.org> <4B47227B.6030603@apache.org> In-Reply-To: <4B47227B.6030603@apache.org> X-Enigmail-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org On 08/01/2010 12:18, Tim Funk wrote: > +1 to trunk > -0 for backport to 6.0.x > > Is this legal? ${'\'}${1+1} > Shouldn't it be: ${'\\'}${1+1} Yes it should. and the Java code to append the \ is: result.append("${'\\\\'}"); This is part of what makes this so tricky to get right. The quoting rules vary between Java, JSPs and EL. A number of the initial failures with my tests were because I had quoted stuff incorrectly in the test case. The good news is that one of my test cases was failing because of exactly this error. As you'll see which my next commit (hopefully later today) things are a lot easier to test and there are a lot more test cases. In fact the majority of the changes will be test cases rather than changes to Jasper/EL. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org