tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: EL issues and 6.0.x release
Date Sun, 31 Jan 2010 01:29:01 GMT
On 30/01/2010 17:41, Mark Thomas wrote:
> On 30/01/2010 07:33, Konstantin Kolinko wrote:
>> Regarding the implementation, AttributeParser.java class. I think
>> that, based on the above, we can fix it to solve bug 48627. Other
>> parts of the new implementation will remain unchanged.
> 
> I'll take another look at this. I thought that this wouldn't work but
> that may because I was doing my testing before I fixed the EL parsing.
> If this doesn't work I have an alternative plan.

Looks like it will work. Just running the TCK to be sure.

>> 1. In JSP 2.1 spec there is an option to selectively disable '#'
>> expressions when '$' ones are still enabled. The name of that option
>> is "deferredSyntaxAllowedAsLiteral".
>>
>> As of now, AttributeParser takes care of isELIgnored option, but does
>> not know about deferredSyntaxAllowedAsLiteral one.
> 
> Probably a bug. We should write some test cases for this first though to
> check.

Yep bug. Test cases written. Fixed. Just running the TCK to be sure.

>> 3. EL spec (ch.1.2.3 of EL 2.1 spec) says that "It is illegal to mix
>> ${} and #{} constructs in a composite expression." though followed by
>> "This restriction may be lifted in future versions".
>>
>> AttributeParser#parseLiteral() has the following clause:
>>
>> } else if (ch == type){
>>
>> I think it has to process '#' and '$' expressions in the same way, and
>> the "mix ${} and #{}" rule should be checked either explicitly here,
>> or elsewhere. I have not researched the question where it is actually
>> checked.
> 
> More tests cases required.

Test case added. This is already handled by the EL impl.

>> Lastly,
>> when Mark was testing TC7 with JSP 2.2 TCK, he caught several minor EL
>> evaluation issues. Those are fixed in TC7, and I think some of them
>> have to be backported to TC6.
> 
> They all need back-porting. I didn't propose them at the time since the
> issues had existing for all of the 6.0.x release and no-one had
> complained. I didn't want to hold up the 6.0.24 release.

Proposed.

Assuming the TCK passes I'll have a fix for 46827 and
deferredSyntaxAllowedAsLiteral shortly.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message