tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r898745 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/juli/FileHandler.java webapps/docs/logging.xml
Date Wed, 13 Jan 2010 16:28:03 GMT
On 13/01/2010 16:24, Konstantin Kolinko wrote:
> There is Mark's patch for that (r898468), but I have doubts
> regarding Runtime.getRuntime().addShutdownHook(new Cleaner());
> used there.

Why? It is pretty much identical to the code in the standard LogManager.

> We could disable log buffering in 6.0.23, to be it the same as in
> 6.0.20 (were logs were not buffered):
> a) by setting bufferSize=0 or -1 explicitly in the default
> logging.properties file
> b) by changing the default value in o.a.juli.FileHandler to disable buffering.
> 
> I am ok with any of a) and b).  Any thoughts?

Buffered logs are useful. Lets just fix not flushing the buffers on shut
down.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message