tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: svn commit: r895700 - /tomcat/native/trunk/native/build/tcnative.m4
Date Tue, 05 Jan 2010 09:54:20 GMT
On 05.01.2010 08:59, jean-frederic clere wrote:
> On 01/04/2010 08:50 PM, Konstantin Kolinko wrote:
>> 2010/1/4<rjung@apache.org>:
>>> Author: rjung
>>> Date: Mon Jan  4 16:58:04 2010
>>> New Revision: 895700
>>>
>>> URL: http://svn.apache.org/viewvc?rev=895700&view=rev
>>> Log:
>>> Fix apr version test i tcnative trunk.
>>>
>>> Modified:
>>>     tomcat/native/trunk/native/build/tcnative.m4
>>>
>>
>>> --- tomcat/native/trunk/native/build/tcnative.m4 (original)
>>> +++ tomcat/native/trunk/native/build/tcnative.m4 Mon Jan  4 16:58:04 2010
>>> @@ -35,8 +35,12 @@
>>>    if test "${1}" -lt "1"; then
>>>      AC_MSG_ERROR(You need APR version 1.3.3 or newer installed.)
>>>    else
>>> -    if test "${2}" -lt "2"; then
>>> +    if test "${2}" -lt "3"; then
>>>        AC_MSG_ERROR(You need APR version 1.3.3 or newer installed.)
>>> +    else
>>> +      if test "${2}" -lt "3"; then
>>> +        AC_MSG_ERROR(You need APR version 1.3.3 or newer installed.)
>>> +      fi
>>>      fi
>>>    fi
>>>
>>
>> I do not understand the above. What is the difference between these checks? :
>>> +    if test "${2}" -lt "3"; then
>>> +      if test "${2}" -lt "3"; then
>
> Should be
>      if test "${2}" -lt "3"; then
>        if test "${3}" -lt "3"; then
> No?

Right, sorry, fixed.

Konstantin: JFC is right, it was meant to also check against the third 
part of the minimum apr version "1 . 3 . 3".

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message