tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject AprLifecycleListener reflective access to o.a.t.jni.Library (was Re: svn commit: r904865)
Date Sat, 30 Jan 2010 20:45:54 GMT
2010/1/30  <markt@apache.org>:
> Author: markt
> Date: Sat Jan 30 20:13:56 2010
> New Revision: 904865
>
> URL: http://svn.apache.org/viewvc?rev=904865&view=rev
> Log:
> Fix Java 1.4/1.5 issues (5.5.x must compile with 1.4)
>
> Modified:
>    tomcat/tc5.5.x/trunk/container/catalina/src/share/org/apache/catalina/core/AprLifecycleListener.java
>

>         // Log APR flags
> -        log.info(sm.getString("aprListener.flags", Library.APR_HAVE_IPV6,
> -                Library.APR_HAS_SENDFILE, Library.APR_HAS_SO_ACCEPTFILTER,
> -                Library.APR_HAS_RANDOM));
> +        log.info(sm.getString("aprListener.flags",
> +                Boolean.valueOf(Library.APR_HAVE_IPV6),
> +                Boolean.valueOf(Library.APR_HAS_SENDFILE),
> +                Boolean.valueOf(Library.APR_HAS_SO_ACCEPTFILTER),
> +                Boolean.valueOf(Library.APR_HAS_RANDOM)));
>         aprAvailable = true;
>     }
>

By the way:
It is odd, that AprLifecycleListener class uses reflection to call the
methods of o.a.t.jni.Library, but later accesses its fields directly.

Is there any meaning behind that?

I do not mind, as far as it works. I am just curious.

I thought that was to be able to separate o.a.t.jni.* into separate
jar, and to be able to run AprLifecycleListener even if that jar is
not available.



Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message