tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r895984 - /tomcat/native/trunk/native/build/tcnative.m4
Date Tue, 05 Jan 2010 11:42:03 GMT
On 05/01/2010, Mladen Turk <mturk@apache.org> wrote:
> On 01/05/2010 11:57 AM, rjung@apache.org wrote:
>
> > Author: rjung
> > Get rid of nested version test by formatting
> > version number as one big decimal.
> >
> > +  decimal_apr_version=`printf %02d%02d%03d ${1} ${2} ${3}`
> > +  if test "${decimal_apr_version}" -lt "0101003"; then
> >
>
>  You should not quote the arithmetic ops though.
>  Also 0101003 is exactly what? 1.1.3 ?

For added safety the format could also be used to generate the comparator.

>  And the format should be %d%d%03d
>  APR has 1-1-N digits in formats.
>  There will never be thing like APR 1.11.X :)
>
>
>  Regards
>  --
>  ^TM
>
>
> ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>  For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message