Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 70854 invoked from network); 23 Dec 2009 08:52:06 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 23 Dec 2009 08:52:06 -0000 Received: (qmail 58360 invoked by uid 500); 23 Dec 2009 08:52:05 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 58279 invoked by uid 500); 23 Dec 2009 08:52:05 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 58268 invoked by uid 99); 23 Dec 2009 08:52:05 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Dec 2009 08:52:05 +0000 X-ASF-Spam-Status: No, hits=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [213.191.128.81] (HELO mxout2.iskon.hr) (213.191.128.81) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Dec 2009 08:51:56 +0000 Received: from mxscanout.iskon.hr (localhost [127.0.0.1]) by localhost (Postfix) with SMTP id 9332E26F8DE for ; Wed, 23 Dec 2009 09:51:30 +0100 (CET) Received: from mx.iskon.hr (unknown [213.191.142.123]) by mxscanout.iskon.hr (Postfix) with SMTP id 1B02526F8C9 for ; Wed, 23 Dec 2009 09:51:30 +0100 (CET) Received: (qmail 16088 invoked from network); 23 Dec 2009 09:51:29 +0100 X-Remote-IP: 89.164.52.18 Received: from 52-18.dsl.iskon.hr (HELO fc12x32m0.jboss.hr) (89.164.52.18) by mx.iskon.hr with SMTP; 23 Dec 2009 09:51:29 +0100 Message-ID: <4B31DA0F.8000304@apache.org> Date: Wed, 23 Dec 2009 09:51:27 +0100 From: Mladen Turk User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Thunderbird/3.0 MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r892800 - in /tomcat/jk/trunk: native/common/jk_status.c xdocs/miscellaneous/changelog.xml References: <20091221123930.5B37C2388996@eris.apache.org> <427155180912222350r5d1b83f8v695b17bcb3ee3254@mail.gmail.com> In-Reply-To: <427155180912222350r5d1b83f8v695b17bcb3ee3254@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: IskonProtect On 12/23/2009 08:50 AM, Konstantin Kolinko wrote: > 2009/12/21: >> Author: mturk >> Date: Mon Dec 21 12:39:29 2009 >> New Revision: 892800 >> >> URL: http://svn.apache.org/viewvc?rev=892800&view=rev >> Log: >> Fix #48305. Skip if property ends with .secret >> >> Modified: >> tomcat/jk/trunk/native/common/jk_status.c >> tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml >> >> + size_t nl = strlen(name); >> + if (nl> sizeof(".secret")&& >> + strcmp(name + nl - 7, ".secret") == 0) { >> + continue; >> + } > > What is sizeof(".secret")? I suppose it is sizeof(char*) that is 4 or > 8, and you are using an explicit '7' on the next line. Right, should be 'sizeof(".secret") - 1'. and sizeof("foo") is 4 -> strlen("foo") + 1 FYI :) -- ^TM --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org