Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 10859 invoked from network); 1 Dec 2009 13:01:15 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 1 Dec 2009 13:01:15 -0000 Received: (qmail 14491 invoked by uid 500); 1 Dec 2009 13:01:14 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 14413 invoked by uid 500); 1 Dec 2009 13:01:14 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 14402 invoked by uid 99); 1 Dec 2009 13:01:14 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Dec 2009 13:01:14 +0000 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [193.252.22.151] (HELO smtp6.freeserve.com) (193.252.22.151) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Dec 2009 13:01:05 +0000 Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf3539.me.freeserve.com (SMTP Server) with ESMTP id 0E9871C000B6 for ; Tue, 1 Dec 2009 14:00:42 +0100 (CET) Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf3539.me.freeserve.com (SMTP Server) with ESMTP id CABD01C01101 for ; Tue, 1 Dec 2009 14:00:41 +0100 (CET) Received: from mx01.dev.local (unknown [91.109.148.103]) by mwinf3539.me.freeserve.com (SMTP Server) with ESMTP id 824E41C000B6 for ; Tue, 1 Dec 2009 13:40:47 +0100 (CET) X-ME-UUID: 20091201124047533.824E41C000B6@mwinf3539.me.freeserve.com Received: from localhost (localhost [127.0.0.1]) by mx01.dev.local (Postfix) with ESMTP id D7D8A324A6 for ; Tue, 1 Dec 2009 12:40:40 +0000 (GMT) X-Virus-Scanned: Debian amavisd-new at homeinbox.net Received: from mx01.dev.local ([127.0.0.1]) by localhost (mx01.dev.local [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pIL21TMryZj7 for ; Tue, 1 Dec 2009 12:40:36 +0000 (GMT) Received: from [192.168.0.9] (study03.dev.local [192.168.0.9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx01.dev.local (Postfix) with ESMTPSA id 361CB324C5 for ; Tue, 1 Dec 2009 12:40:36 +0000 (GMT) Message-ID: <4B150EBA.6090506@apache.org> Date: Tue, 01 Dec 2009 12:40:26 +0000 From: Mark Thomas User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: WebDAV servlet returns 500 if files not readable References: In-Reply-To: X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Martin Carpenter wrote: > Hello, > > I have an issue with the standard WebDAV servlet bundled with Tomcat 5.5 > and 6.0 (tested 5.5.26 and 6.0.20) that is causing me some pain. If a > directory contains a file that is not readable by the tomcat process (eg > file permissions, dangling symlink) then TC throws a NullPointerException > and returns a 500 Internal Server Error to the client. I think this > is incorrect behavior and that it should at least list the files in a > directory even if they are not all accessible to the user. > > I couldn't see this issue reported in the BugZilla or on this list. Please create a new issue. > This seems like a better solution but I worry about other dependencies on > the existing behaviour. How is test coverage? Tomcat unit tests are non-existent for this. I tend to use the litmus test suite for WebDAV testing. > Any other advice on how best to solve this appreciated! I'm tempted to say any inaccessible file should just be ignored. However, that could cause issues if a user tries to upload a file of that name. Certainly, any such configuration isn't valid so returning an error to the user and logging an error isn't too unreasonable. Maybe better error reporting is the way to go with this one. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org