tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r885860 - in /tomcat/trunk: java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java java/org/apache/catalina/core/LocalStrings.properties webapps/docs/config/listeners.xml
Date Wed, 02 Dec 2009 12:44:23 GMT
Bill Barker wrote:
> <markt@apache.org> wrote in message 
> news:20091201184432.F013223889D0@eris.apache.org...
>> Author: markt
>> Date: Tue Dec  1 18:44:32 2009
>> New Revision: 885860
>>
>> URL: http://svn.apache.org/viewvc?rev=885860&view=rev
>> Log:
>> More memory leak protection - this time for the GC Daemon thread.
>>
>> log.error(sm.getString("jreLeakListener.gcDaemonFail"), e);
> 
> This should be no higher than INFO (and, personally, would go for DEBUG). 
> It just means that you are not running a Sun JVM.  IMHO, having this one at 
> ERROR just produces messages on the user list of the form "I got this big 
> scary message in my log file while running Tomcat on the latest IBM JVM. 
> What do I do about it?".

Fair point. I thought I had caught all of those after my original
copy/paste of the error handling. Clearly not.

I'll get that fixed and probably add a test to see if we are on a Sun
JVM and log accordingly.

Cheers,

Mark




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message