tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: svn commit: r891310 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/loader/WebappClassLoader.java java/org/apache/catalina/security/SecurityClassLoad.java
Date Thu, 17 Dec 2009 03:01:30 GMT
2009/12/16 sebb <sebbaz@gmail.com>:
> On 16/12/2009, markt@apache.org <markt@apache.org> wrote:
>> Author: markt
>>  Date: Wed Dec 16 16:56:22 2009
>>  New Revision: 891310
>>
>>  URL: http://svn.apache.org/viewvc?rev=891310&view=rev
>
>>  +
>>  +    /**
>>  +     * @deprecated Not used
>>  +     */
>
> Doesn't this need the annotation:
>
>       @Deprecated ?
>
>>      protected class PrivilegedFindResource
>>          implements PrivilegedAction {
>>

I think that nobody cares.

In TC 6 there are 6 occurrences of @Deprecated and 150+ of /* @deprecated */.

When preparing the patch, that Mark applied, I went for the most
frequent option. I do not think that this inner class needs any
emphasis, as it is not some public API.

If anyone wants to add @Deprecated there, here is my +1 for that, but
I do not really care.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message