tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject DO NOT REPLY [Bug 48258] Creating a session cookie with a specific default domain.
Date Wed, 02 Dec 2009 00:42:59 GMT

--- Comment #5 from Mark Thomas <> 2009-12-01 16:42:58 GMT ---
The general approach is good.

Some misc comments in no particular order:
- Use 4 spaces rather than tabs
- Remove the changes that just add/remove whitespace at the end of a line
- Some methods are missing JavaDocs
- Provide the spelling corrections as a separate patch (makes things easier to
- The new attribute needs documenting.
- Some thought needs to be given to how this will interact with the session
cookie config that will come in the Tomcat 7.

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message