tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r882008 - /tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java
Date Thu, 19 Nov 2009 00:50:33 GMT
Konstantin Kolinko wrote:
> 2009/11/19 Mark Thomas <markt@apache.org>:
>> Konstantin Kolinko wrote:
>>> twice the same condition
>> Thanks - I'll fix that.
>>
> 
> OK, seen that.
> 
> On second thought:
> it is strange to synchronize on "this" to set a static field. That should be
> synchronized(getClass())

Fair point, although I doubt this code is ever actually called in Tomcat...

Fixed.

Mark




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message