tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r836113 - in /tomcat/trunk: java/org/apache/tomcat/util/http/ test/org/apache/tomcat/util/http/ webapps/docs/config/
Date Sat, 14 Nov 2009 13:47:09 GMT
sebb wrote:
> public arrays are not immutable - entries can be changed accidentally
> or maliciously.

I know.

> As far as I can tell, the arrays could be made private without
> breaking any code.

Good point. In all the refactoring, I missed that. I'll make those changes now.

> It looks like some/all of the booleans could also be made private -
> why expose fields unnecessarily?

Ditto.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message