tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkoli...@apache.org
Subject svn commit: r831847 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt
Date Mon, 02 Nov 2009 10:23:06 GMT
Author: kkolinko
Date: Mon Nov  2 10:23:06 2009
New Revision: 831847

URL: http://svn.apache.org/viewvc?rev=831847&view=rev
Log:
veto and proposal

Modified:
    tomcat/tc5.5.x/trunk/STATUS.txt
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=831847&r1=831846&r2=831847&view=diff
==============================================================================
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Mon Nov  2 10:23:06 2009
@@ -37,7 +37,18 @@
   http://people.apache.org/~markt/patches/2009-08-16-bug39231.patch
   JAAS LoginContext expects a call to logout()
   +1: markt, fhanik
-  -1: 
+  -1: kkolinko: It works for classes that call JAASRealm#createPrincipal(String,Subject),
+    but breaks those ones that overwrite that method, because overwritten
+    method will not be called by the base class. An alternative patch is proposed below.
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=39231
+  It is updated version of Mark's patch,
+  where the new method in JAASRealm calls the old one.
+  http://people.apache.org/~kkolinko/patches/2009-11-02_bug39231.patch
+  +1: kkolinko
+  -1:
+
+ 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=39844
   Port r588477 (fix for #43668) by billbarker that corrected this for Tomcat 6

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=831847&r1=831846&r2=831847&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Nov  2 10:23:06 2009
@@ -132,7 +132,17 @@
   http://people.apache.org/~markt/patches/2009-08-16-bug39231.patch
   JAAS LoginContext expects a call to logout()
   +1: markt, jim, fhanik
-  -1: 
+  -1: kkolinko: It works for classes that call JAASRealm#createPrincipal(String,Subject),
+    but breaks those ones that overwrite that method, because overwritten
+    method will not be called by the base class. An alternative patch is proposed below.
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=39231
+  It is updated version of Mark's patch,
+  where the new method in JAASRealm calls the old one.
+  http://people.apache.org/~kkolinko/patches/2009-11-02_bug39231.patch
+  +1: kkolinko
+  -1:
+
  
 * Improve NIO connector shutdown time by doing shutdowns in parallel
   and with a timeout



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message