tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject DO NOT REPLY [Bug 47330] proposal : port of mod_remoteip in Tomcat as RemoteIpValve
Date Mon, 02 Nov 2009 02:33:04 GMT

--- Comment #4 from Mark Thomas <> 2009-11-01 18:32:58 GMT ---
Created an attachment (id=24455)
 --> (
Tomcat 7 patch with completed TODOs and failing test case

Many thanks for these patches. I'd like to add the valve and filter to Tomcat 7
and the valve to Tomcat 6. I have made the necessary changes to Tomcat 7 the
valve can sit in the right package.

When I applied the patch, I completed the TODOs and added some documentation.
However, one of the test cases failed and my initial investigation suggests
that the patch needs further work.

I have attached my final Tomcat 7 patch. Please update as necessary to correct
the failing test case and then I'll apply it. Once the valve is applied, I'll
look a the filter which will probably be generated by porting the final version
of the valve.

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message