tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 47364] HttpServletRequest.getAttributeNames() does not return the names of all attributes
Date Sun, 01 Nov 2009 18:20:39 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=47364

--- Comment #2 from Mark Thomas <markt@apache.org> 2009-11-01 10:20:36 GMT ---
Created an attachment (id=24451)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24451)
Patch that adds internal attributes but breaks TCK tests

I looked at just including all the Tomcat internal attributes in the return
from getAttributeNames() but this causes problems with the Servlet 2.5 TCK
tests which expect that getAttributeNames() return only those attributes that
have been set via setAttribute().

Therefore it looks like the doc change is the way I'll have to go. For
completeness the patch I tried that returned all the attribute names is
attached so you can patch Tomcat locally if you particularly need that
functionality. I thought about making this a configurable option but I didn't
want to add the complexity for something that I couldn't see causing any
problems that can't be easily worked around by an app that needed to.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message