tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r821438 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt
Date Sun, 04 Oct 2009 16:05:26 GMT
kkolinko@apache.org wrote:
> @@ -316,10 +317,19 @@
>    Make maxThreads return consistent. Will still return -1 in many cases but that
>    is better than previously.
>    https://issues.apache.org/bugzilla/attachment.cgi?id=24341&action=edit
> -  +1: markt
> -  -1: 
> +  +1: markt, kkolinko
> +  -1:
> +  kkolinko: (We need to make some decision regarding the following lines in Http11Processor#process():
> +        int threadRatio = (endpoint.getCurrentThreadsBusy() * 100)
> +                / endpoint.getMaxThreads();
> +    When JIoEndpoint uses an executor this value that was (-100) will now be (+100).
> +    I am in favour of using the (threadRatio <= 75) branch when threadRatio
> +    cannot be reliably calculated.
> +
> +    Besides that, I see no problems with this patch.
> +  )

That's bad. I'll take another look.

Mark




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message