tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: svn commit: r823351 - in /tomcat/trunk/java/org/apache: coyote/http11/AbstractInputBuffer.java coyote/http11/Http11Processor.java coyote/http11/InternalInputBuffer.java coyote/http11/InternalNioInputBuffer.java tomcat/util/net/JIoEndpoint.java
Date Fri, 09 Oct 2009 06:52:11 GMT
2009/10/9  <fhanik@apache.org>:
> Author: fhanik
> Date: Thu Oct  8 22:37:52 2009
> New Revision: 823351
>
> URL: http://svn.apache.org/viewvc?rev=823351&view=rev
> Log:
> consolidate two input buffers into one, no functional change, just abstract out exact
same code used in two connectors
>
> Added:
>    tomcat/trunk/java/org/apache/coyote/http11/AbstractInputBuffer.java
> Modified:
>    tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java
>    tomcat/trunk/java/org/apache/coyote/http11/InternalInputBuffer.java
>    tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java
>    tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
>

AbstractHttp11Processor.java
AbstractInputBuffer.java
both do not have svn:eol-style and svn:keywords

Also, may be
1. The AbstractHttp11Processor to be declared as "abstract"
2. The AbstractInputBuffer#log to be made non-static and use
this.getClass().getName() (and remove Http11Processor#log, #sm and
Http11NioProcessor#log, #sm)

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message