tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkoli...@apache.org
Subject svn commit: r821438 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt
Date Sat, 03 Oct 2009 22:35:12 GMT
Author: kkolinko
Date: Sat Oct  3 22:35:11 2009
New Revision: 821438

URL: http://svn.apache.org/viewvc?rev=821438&view=rev
Log:
votes

Modified:
    tomcat/tc5.5.x/trunk/STATUS.txt
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=821438&r1=821437&r2=821438&view=diff
==============================================================================
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Sat Oct  3 22:35:11 2009
@@ -160,5 +160,5 @@
 
 * Upgrade to Commons-Pool 1.5.3. 1.5.2 had a leak
   http://svn.apache.org/viewvc?rev=821412&view=rev
-  +1: markt
+  +1: markt, kkolinko
   -1: 

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=821438&r1=821437&r2=821438&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sat Oct  3 22:35:11 2009
@@ -206,8 +206,9 @@
   http://svn.apache.org/viewvc?rev=810916&view=rev
   http://svn.apache.org/viewvc?rev=810977&view=rev
   http://svn.apache.org/viewvc?rev=821397&view=rev
-  +1: markt
+  +1: markt, kkolinko
   -1:
+  kkolinko: re RUNNING.txt update: it'd be better to replace "eg" with "e.g."
 
 * Allow per instance configuration of JULI or log4j for core Tomcat logging
   This requires the classpath change above
@@ -316,10 +317,19 @@
   Make maxThreads return consistent. Will still return -1 in many cases but that
   is better than previously.
   https://issues.apache.org/bugzilla/attachment.cgi?id=24341&action=edit
-  +1: markt
-  -1: 
+  +1: markt, kkolinko
+  -1:
+  kkolinko: (We need to make some decision regarding the following lines in Http11Processor#process():
+        int threadRatio = (endpoint.getCurrentThreadsBusy() * 100)
+                / endpoint.getMaxThreads();
+    When JIoEndpoint uses an executor this value that was (-100) will now be (+100).
+    I am in favour of using the (threadRatio <= 75) branch when threadRatio
+    cannot be reliably calculated.
+
+    Besides that, I see no problems with this patch.
+  )
 
 * Upgrade to Commons-Pool 1.5.3. 1.5.2 had a leak
   http://svn.apache.org/viewvc?rev=821412&view=rev
-  +1: markt
+  +1: markt, kkolinko
   -1: 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message