tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fha...@apache.org
Subject svn commit: r821027 - /tomcat/tc6.0.x/trunk/STATUS.txt
Date Fri, 02 Oct 2009 14:07:12 GMT
Author: fhanik
Date: Fri Oct  2 14:07:12 2009
New Revision: 821027

URL: http://svn.apache.org/viewvc?rev=821027&view=rev
Log:
votes

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=821027&r1=821026&r2=821027&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Oct  2 14:07:12 2009
@@ -202,30 +202,6 @@
    0: jim
   -1: 
 
-* Fix VirtualWebappLoader file directives
-  Index: java/org/apache/catalina/loader/VirtualWebappLoader.java
-===================================================================
---- java/org/apache/catalina/loader/VirtualWebappLoader.java	(revision 810099)
-+++ java/org/apache/catalina/loader/VirtualWebappLoader.java	(working copy)
-@@ -92,9 +92,9 @@
-                 continue;
-             }
-             if (file.isDirectory()) {
--                addRepository("file:/" + file.getAbsolutePath() + "/");
-+                addRepository("file://" + file.getAbsolutePath() + "/");
-             } else {
--                addRepository("file:/" + file.getAbsolutePath());
-+                addRepository("file://" + file.getAbsolutePath());
-             }
-         }
-
-  +1: fhanik
-  -1: kkolinko: (either way does not properly escape symbols, such as '%'.
-  file.toURI().toString() has to be used here. See discussion. - Patch is
-  proposed below (?rev=820954). )
-  rjung: Note discussion at http://marc.info/?t=125182574600001&r=1&w=2
-  fhanik @rjung: The scheme for file:// has two slashes, that's the definition.
-
 * Allow per instance log4j.properties, JAR files (JDBC drivers) etc
   http://svn.apache.org/viewvc?rev=810916&view=rev
   http://svn.apache.org/viewvc?rev=810977&view=rev
@@ -305,7 +281,7 @@
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47824
   Correct Maven deps
   http://svn.apache.org/viewvc?rev=813866&view=rev
-  +1: markt, rjung
+  +1: markt, rjung,fhanik
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47796
@@ -331,7 +307,7 @@
   Note: Patch cannot be applied until tc-native 1.1.17 has been released
         since it depends on a new native method
   http://svn.apache.org/viewvc?rev=815418&view=rev
-  +1: markt, jfclere
+  +1: markt, jfclere, fhanik
    0: jim
   -1: 
 
@@ -339,7 +315,7 @@
   Correctly report thread counts when using executors
   https://issues.apache.org/bugzilla/attachment.cgi?id=24272
   +1: markt, rjung
-  -1: 
+  -1: fhanik - this creates a package dependency we've been avoiding so far. Its not the
connectors job to report thread count if an executor is used.
   rjung: Maybe we should add a few getters to org.apache.catalina.Executor
   for TC 7, so we can assume everyone providing an implementation
   allows us to query? If they don't use threads, they can return -1 or whatever.



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message