tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 47867] New: IIS connector compiled with VS2008 crashes, when worker contains unsupported properties
Date Fri, 18 Sep 2009 08:28:14 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=47867

           Summary: IIS connector compiled with VS2008 crashes, when
                    worker contains unsupported properties
           Product: Tomcat Connectors
           Version: 1.2.26
          Platform: PC
        OS/Version: Windows Server 2003
            Status: NEW
          Severity: minor
          Priority: P2
         Component: Common
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: indrek.juhani@voipster.com


Created an attachment (id=24289)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24289)
Patch terminates native/common/jk_util.c:supported_properties array with NULL

The 1.2.26 was re-compiled with VS2008. The workers file contained accidentally
a worker property introduced by 1.2.27. The IIS connector crashes during
initialization with memory access error.

The problem is, that native/common/jk_util.c:supported_properties array does
not end with NULL. In case of wrong property, the pointer will go out of bounds
in
native/common/jk_util.c:jk_is_valid_property function.

The officail binary release DLL of 1.2.26 from Apache will print:

[error] jk_map.c (403): The attribute 'worker.gw1.ping_mode' is not supported -
please check the documentation for the supported attributes.

and does not cause crash. This could be because VC++ 6.0 (which is used for
official binary builds as I understand) uses different memory alignment/layout
or something else. Anyway, I think it is safer not to permit run pointer out of
array and explicitly mark the end of list with NULL.

Proposed fix is attached as patch.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message