tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 47834] TldConfig throws Exception when exploring unpacked jar
Date Mon, 14 Sep 2009 16:53:45 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=47834

--- Comment #4 from Mark Thomas <markt@apache.org> 2009-09-14 17:53:44 BST ---
(In reply to comment #3)
Thanks for the testing.

> In tldScanWebInfLib(), when you get the resource paths from WEB-INF/lib, my jar
> file is there, but the String is of the form: "<something>.jar/". The trailing
> '/' is a problem because you test for ".jar" only.
That is expected. Exploded jar files should be dealt with
tldScanClassloaders(). You'll need to set the
org.apache.jasper.compiler.TldLocationsCache.SCAN_CLASSPATH system property as
well as ...SCAN_ALL_FILES and ...SCAN_ALL_DIRS

> Anyway, even if something was found, I think the current code is wrong in
> handling directories: in tldScanJar() the first thing we do is opening the URL
> to get the URLConnection. If the URL is referring to a directory, we will very
> quickly get an IOException.
Hmm. I didn't see that in my testing. I doubt I tested all possible code paths
though.

> I'll work on a refined patch tomorrow.
Great.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message