Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 78686 invoked from network); 12 Aug 2009 17:16:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 12 Aug 2009 17:16:13 -0000 Received: (qmail 99347 invoked by uid 500); 12 Aug 2009 17:16:19 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 99250 invoked by uid 500); 12 Aug 2009 17:16:19 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 99231 invoked by uid 99); 12 Aug 2009 17:16:19 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Aug 2009 17:16:19 +0000 X-ASF-Spam-Status: No, hits=-2.8 required=10.0 tests=RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [66.187.237.31] (HELO mx2.redhat.com) (66.187.237.31) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Aug 2009 17:16:10 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7CHFmti001570 for ; Wed, 12 Aug 2009 13:15:48 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n7CHFm1W029459 for ; Wed, 12 Aug 2009 13:15:48 -0400 Received: from fc11x64m0.jboss.hr (vpn-10-43.str.redhat.com [10.32.10.43]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n7CHFkP0011352 for ; Wed, 12 Aug 2009 13:15:47 -0400 Message-ID: <4A82F8C2.2090309@apache.org> Date: Wed, 12 Aug 2009 19:15:46 +0200 From: Mladen Turk User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2 MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: Making AJP secret attribute consistent References: <4A7836E9.6060604@apache.org> <427155180908120618n3012a63eq73d69c1e99413638@mail.gmail.com> In-Reply-To: <427155180908120618n3012a63eq73d69c1e99413638@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 X-Virus-Checked: Checked by ClamAV on apache.org On 12/08/09 15:18, Konstantin Kolinko wrote: > 2009/8/4 Mladen Turk: >> Hi, >> >> JK connector uses the request.secret attribute for setting the >> AJP secret property. However APR connector and Ajp connector >> use the requiredSecret instead. This of course (first problem is >> that it's nowhere documented) makes problems cause it requires to >> have separate directives depending on the connector. >> >> Since attributes having dot in the name cannot be parsed using >> standard xml property getter I propose we add the same property >> to the JK connector and deprecate old dot name (request.secret) >> >> Comments? >> >> Regards >> -- >> ^TM > > 1. I do not see "requiredSecret" in documentation. Thus the problem is > that it is not documented. > Already said that ;) > 2. There are quite a lot of properties that use a dot in their name. See here: > http://tomcat.apache.org/tomcat-6.0-doc/config/ajp.html > http://tomcat.apache.org/tomcat-6.0-doc/config/http.html > (Index> Configuration Reference> AJP , /> HTTP ) > Other option is to use required.secret instead requiredSecret Much easier because requiredSecret isn't document, so one can only find it browsing the source code. However dunno how to make it using current property set/get methods Regards -- ^TM --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org