tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Barker" <billwbar...@verizon.net>
Subject Re: Making AJP secret attribute consistent
Date Fri, 14 Aug 2009 02:35:24 GMT
Since Mark has already removed the o.a.jk connector from trunk, I'd prefer 
to just fix the docs there and use requiredSecret etc. In the other branches 
it is easy enough to teach the o.a.jk connector to accept requiredSecrect as 
an alias for request.secrect, so even here I'd vote to add the alias and 
change the docs.

"Konstantin Kolinko" <knst.kolinko@gmail.com> wrote in message 
news:427155180908131702v4778a5ffj84770f36e2d0c407@mail.gmail.com...
2009/8/13 Mladen Turk <mturk@apache.org>:
> On 13/08/09 19:43, Konstantin Kolinko wrote:
>>>
>>> Other option is to use required.secret instead requiredSecret
>>> Much easier because requiredSecret isn't document, so one
>>> can only find it browsing the source code.
>>>
>>> However dunno how to make it using current property set/get methods
>>>
>>
>> I have just noticed - the following patch (as currently proposed for
>> tc6.0) is an example of implementing such a dot property
>> ("socket.unlockTimeout"):
>>
>> * Improve NIO connector shutdown time by doing shutdowns in parallel
>> and with a timeout
>> http://svn.apache.org/viewvc?view=rev&revision=791914
>>
>> I have not dug into details yet, though.
>>
>
> It looks like magic ;)
> I always thought that setName(...) reflects name="...",
> now it seems it's possible to have setName(...) and socket.name="..."
>

... The implementation, in this case, is in NioEndpoint#setProperty()
 {
        final String selectorPoolName = "selectorPool.";
        final String socketName = "socket.";
            if (name.startsWith(selectorPoolName)) {
                return IntrospectionUtils.setProperty(...);
            } else if (name.startsWith(socketName)) {
                return IntrospectionUtils.setProperty(...);
            } else {
                return IntrospectionUtils.setProperty(this,name,value);
            }
}

and it is o.a.tomcat.util.IntrospectionUtils#setProperty(..) that
looks for the "setProperty" method if explicit setter is not
available.

Best regards,
Konstantin Kolinko 




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message