tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: Regarding JAAS logout patch (for bug 39231)
Date Sun, 16 Aug 2009 15:21:20 GMT
Konstantin Kolinko wrote:
> The following patch is currently in voting for 5.5 and 6.0
> 
> * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=39231
>   http://svn.apache.org/viewvc?rev=791900&view=rev
>   http://svn.apache.org/viewvc?rev=792446&view=rev (Filip's suggestion)
>   JAAS LoginContext expects a call to logout()
> 
> I have some comments on it.
> 
> 1. It changes signature of JAASRealm.createPrincipal(), adding the
> third argument,
> and that will break classes that override that method.
> 
> While evaluating this case I stumbled upon a library that will be
> broken by this change:
> JOSSO (Java Open Single Sign-On Project).

That is a good enough reason for a veto in my book. I'll fix the patch.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message