tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r803794 - /tomcat/tc6.0.x/trunk/STATUS.txt
Date Sat, 15 Aug 2009 12:04:09 GMT
kkolinko@apache.org wrote:
> +  -1: kkolinko: (
> +      FileDirContext#file() contains a check that file.canRead() is true.
> +      A side-effect of this patch will be that files that are not readable
> +      will be excluded from the enumeration provided by FileDirContext#list()
> +      or FileDirContext#listBindings().
> +      I think that it is wrong. If file is not readable it should result in error 404
> +      or something like that.

I think that point is debatable but...

> +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45403
> +  Add a check when enumerating jar files, and
> +  do not suppress IO errors when starting a web application.
> +  Note:
> +    - I cannot test bug 45403 on Windows, as it is Un*x-specific

I assume you mean that you haven't been able to test this on *nix. If
not, ignore most of what I have written below :)

There are a couple of options here.
As an Apache committer, you can apply for a full MSDN license. This
should come up again shortly as the current licenses expire in November.
You could then use MS's virtual server.

I use VMWare Workstation (which you have to pay for) but VMWare server
is available for free and should do what you need to do to test stuff on
*nix.

> +    - tested in normal operation, with unpackWARs = "true" and "false"
> +    - this has not yet been applied to trunk

It works for me on linux so I will revert my patch in trunk and apply
your alternative.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message