tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jean-frederic clere <jfcl...@gmail.com>
Subject Re: BIO connector - upload timeout
Date Tue, 11 Aug 2009 07:25:07 GMT
On 08/10/2009 11:17 PM, Filip Hanik - Dev Lists wrote:
> On 08/10/2009 12:46 PM, Mark Thomas wrote:
>> Filip Hanik - Dev Lists wrote:
>>> Http11Processor.java
>>>
>>> inputBuffer.parseRequestLine();
>>> request.setStartTime(System.currentTimeMillis());
>>> keptAlive = true;
>>> if (disableUploadTimeout) {
>>> socket.setSoTimeout(soTimeout);
>>> } else {
>>> socket.setSoTimeout(timeout);
>>> }
>>> inputBuffer.parseHeaders();
>>>
>>> Isn't the condition reversed here?
>>> If I set disableUploadTimeout=true, shouldn't we then set the 5min
>>> timeout (socket.setSoTimeout(timeout).
>>
>> No.
>>
>> disableUploadTimeout==true means disable the special upload timeout and
>> use the standard socket timout (soTimeout)
>>
>> disableUploadTimeout==false means use the special upload timeout
>> (timeout)
> I see, I always thought it was the other way. since tomcat by default
> had a "special" upload timeout :)

Couldn't we just have a UploadTimeout parameter, so that if set use it, 
if not default to timeout?

Cheers

Jean-Frederic

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message