tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Hanik - Dev Lists <devli...@hanik.com>
Subject Re: BIO connector - upload timeout
Date Mon, 10 Aug 2009 21:17:09 GMT
On 08/10/2009 12:46 PM, Mark Thomas wrote:
> Filip Hanik - Dev Lists wrote:
>    
>> Http11Processor.java
>>
>> inputBuffer.parseRequestLine();
>>                  request.setStartTime(System.currentTimeMillis());
>>                  keptAlive = true;
>>                  if (disableUploadTimeout) {
>>                      socket.setSoTimeout(soTimeout);
>>                  } else {
>>                      socket.setSoTimeout(timeout);
>>                  }
>>                  inputBuffer.parseHeaders();
>>
>> Isn't the condition reversed here?
>> If I set disableUploadTimeout=true, shouldn't we then set the 5min
>> timeout (socket.setSoTimeout(timeout).
>>      
>
> No.
>
> disableUploadTimeout==true means disable the special upload timeout and
> use the standard socket timout (soTimeout)
>
> disableUploadTimeout==false means use the special upload timeout (timeout)
>    
I see, I always thought it was the other way. since tomcat by default 
had a "special" upload timeout :)
and we could disable it.
thanks for the clarification.

Filip

>    
>> If I read the code correctly, we
>> do the opposite.
>>      
>
> There are too many negatives in the code which causes confusion but the
> current trunk code is correct. It wasn't right for a long time. See:
> http://svn.apache.org/viewvc?view=rev&revision=744160
> and
> http://svn.apache.org/viewvc?view=rev&revision=763262
>
> Mark
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>    


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message