tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Hanik - Dev Lists <devli...@hanik.com>
Subject BIO connector - upload timeout
Date Mon, 10 Aug 2009 14:22:08 GMT
Http11Processor.java

inputBuffer.parseRequestLine();
                 request.setStartTime(System.currentTimeMillis());
                 keptAlive = true;
                 if (disableUploadTimeout) {
                     socket.setSoTimeout(soTimeout);
                 } else {
                     socket.setSoTimeout(timeout);
                 }
                 inputBuffer.parseHeaders();

Isn't the condition reversed here?
If I set disableUploadTimeout=true, shouldn't we then set the 5min 
timeout (socket.setSoTimeout(timeout). If I read the code correctly, we 
do the opposite.

Filip


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message