Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (athena.apache.org: domain of knst.kolinko@gmail.com
 designates 209.85.218.221 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=KN1fSiH2DV00Bj82HEzSm8RTMfaewp4Uf4F+N72QeZMWrsq3j3Zo/3U9N8tfXaciLU
         oPE5yzVzUpOsOBTihfWRXFIzTFgjr9HwsE/1UVsBCQ/VkdvYcYC8VB3duWDB8MysrR77
         JGn0VaKW5uzXfRzHnDD3B0LfDKMDbA4RzrAAM=
MIME-Version: 1.0
In-Reply-To: <20090709090652.56A2B2388877@eris.apache.org>
References: <20090709090652.56A2B2388877@eris.apache.org>
Date: Fri, 10 Jul 2009 01:53:04 +0400
Message-ID: <427155180907091453h5bd4dccdse813a01416a5c9cd@mail.gmail.com>
Subject: Re: svn commit: r792462 - /tomcat/current/tc5.5.x/STATUS.txt
From: Konstantin Kolinko <knst.kolinko@gmail.com>
To: Tomcat Developers List <dev@tomcat.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

2009/7/9  <markt@apache.org>:
> Author: markt
> Date: Thu Jul =A09 09:06:51 2009
> New Revision: 792462
>
> URL: http://svn.apache.org/viewvc?rev=3D792462&view=3Drev
> Log:
> Suggest alternative approach
>
> Modified:
> =A0 =A0tomcat/current/tc5.5.x/STATUS.txt
>
> =A0 =A0 (well, even now one can set CLASSPATH there, or add tools.jar to
> =A0 =A0 common.loader of catalina.properties - haven't tried the latter)
> =A0 =A0 Though we already have a switch that controlls configuration: "-s=
ecurity".
> + =A0markt:
> + =A0 =A0How about an alternative approach that removes the javac command=
 completely
> + =A0 =A0rather than trying to fix it? As has been pointed out, setenv ca=
n be used to
> + =A0 =A0achieve the same end and is more consistent with how we do thing=
s now,
>

Yes. I would like javac there to be removed completely.


I would like adding tools.jar to the classpath to be also completely
removed. How others think about it? The docs can then be made
consistent with implementation.

The way how tools.jar is added under Unix now (in setclasspath.sh) is
definitely odd (both 5.5 and 6.0):
if [ "$1" =3D "debug" -o "$1" =3D "javac" ] ; then
  CLASSPATH=3D"$JAVA_HOME"/lib/tools.jar
fi
There is no need to add tools.jar when running with jdb. Jdb does not
need it. Thus actually we can count it as never added, on Unix.
Also, if CLASSPATH was set by user, the above code completely
redefines it, and that is wrong.


In Windows bat files the tools.jar is always added (in 5.5; with
existence check in 6.0), but I won't mind removing it from there, for
consistency, and as hardly anyone uses them in production. The exe
installer on Windows (I tried the 5.5 one) does not add tools.jar to
the classpath.


Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org