tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 47609] New: Failsafe EOL conversion
Date Thu, 30 Jul 2009 18:52:51 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=47609

           Summary: Failsafe EOL conversion
           Product: Tomcat 5
           Version: 5.5.27
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Native:Packaging
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: sebb@apache.org


Created an attachment (id=24066)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24066)
List of extensions used in 5.5.28

The builds/build.xml file has the following code:

  <target name="package-src-tgz">
    <fixcrlf srcdir="${tomcat.dist}/src"
       
excludes="**/*.bin,**/*.bmp,**/*.dia,**/*.exe,**/*.gif,**/*.ico,**/*.jar,**/*.jpg,**/*.pdf,**/*.rtf,**/*.war"
        eol="lf"
        encoding="ISO-8859-1" fixlast="false" />

The intention is to fix all the source files so that they are readable on Unix
(LF) systems.

However, the command is inherently unsafe - if a new binary file is added with
an extension that is not listed, then the file will be damaged. In general it
is impossible to reverse LF-conversion on a binary file.

It would be much safer to use includes instead. If a new source file type is
added, then the worst that can happen is that the file is awkard to read on
Unix. Unlike the case with binary files, the file can still be converted
successfully.

The current list of extensions that are present in the 5.5.28 source archive
are included in the file "extensions.txt".

At least two binary extensions (.db, .keystore) are currently missing from the
excludes list.

There are quite a few files with no extension. These appear to be all text
files, and are listed in the file "no-extension.txt" (duplicate names have been
removed).

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message