tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: svn commit: r790296 - /tomcat/current/tc5.5.x/STATUS.txt
Date Wed, 01 Jul 2009 20:11:53 GMT
On 01.07.2009 22:03, Mark Thomas wrote:
> Rainer Jung wrote:
>> On 01.07.2009 20:14, markt@apache.org wrote:
>>>  * Fix small memory leak found by find bugs.
>>>    Backport of http://svn.apache.org/viewvc?view=rev&revision=717906 from
tc6
>>>    resp. http://svn.apache.org/viewvc?view=rev&revision=735645 from OACC.
>>>    +1: rjung, kkolinko
>>> +  +1: markt - patch does much more than fix a memory leak
>>>    -1:
>> Yes, I wondered a bit too, but I took over the commit message and
>> changelog entry from your r717906 and r699634.
>>
>> I guess findbugs flagged it as a leak.
>>
>> Should we change the respective changelog entries?
> 
> The current change logs look fine to me. My only point was that 735645
> covers two issues so your proposal in the status file should note both,
> as should the commit message when you apply this to 5.5.x
> 
> I am happy with both fixes being back ported.

Ah, I understand. The commit only contains the simple one of the two
OACC fixes, the other one is one of the bigger patches not being
packported to tc 5.5 but somehow being risky and maybe not worth
applying to 5.5.x. I'll fix the commit message.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message