Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (athena.apache.org: domain of knst.kolinko@gmail.com
 designates 209.85.218.225 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=ajxXSg6uQklfzjlfEMhifyM66faaoji0rEw+k8SLW+uRU4pwvV9FmpNskoH1IkXK3U
         r5CI2X0pH0xVEcGEm9aoUAWc0n//Zfza+9Yfty4t9eUKxpwlAO7xkzNLsLYJxeX+bpwj
         j6wDt/Lqw6zvCLE7X4QjF3MRF37N17RZBlrLI=
MIME-Version: 1.0
In-Reply-To: <4A3115FC.70306@apache.org>
References: <20090611141650.47033238886C@eris.apache.org>
	 <4A3115FC.70306@apache.org>
Date: Thu, 11 Jun 2009 20:13:21 +0400
Message-ID: <427155180906110913g574ebf8p8204be344fca9676@mail.gmail.com>
Subject: Re: svn commit: r783779 -
 /tomcat/trunk/java/org/apache/tomcat/util/buf/HexUtils.java
From: Konstantin Kolinko <knst.kolinko@gmail.com>
To: Tomcat Developers List <dev@tomcat.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

2009/6/11 Mark Thomas <markt@apache.org>:
> markt@apache.org wrote:
>> Author: markt
>> Date: Thu Jun 11 14:16:49 2009
>> New Revision: 783779
>>
>> URL: http://svn.apache.org/viewvc?rev=783779&view=rev
>> Log:
>> Experiment with the UCDetector (Unused Code Detector) plug-in for Eclipse.
>> Remove all the code from the class that isn't used anywhere in Tomcat.
>
> Early indications are that this plug-in is going to find quite a bit of
> code that can de deleted or restricted in visibility.
>
> What are people's thoughts on running this over the entire code base?
>
> I would image that, if done, this would be done gradually, like the
> conversion to use generics.
>
> Mark
>

If you want to do it, then why not? It is your time to spend.

It is good to have some automated code review now before TC 7,
because it may be hard to fix some issues once it is released.

My experience with such tools is that you need to specify some
set of "entry points", including possible reflection calls and
classes specified through configuration, etc. and that may be hard.

I do not know how hard it will be with this tool, and how many
"// NO_UCD" comments [1] will be needed to dispose most of
false positives.  That will be your experience.

[1] http://www.ucdetector.org/

But, certainly, running a tool must be easier than doing manual
review

In one of my last projects I used coverage results to find unused code.
(Thanks to EclEmma plugin for Eclipse).
Those results, though require much more work, are more reliable.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org