Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (nike.apache.org: local policy)
Message-Id: <6E693956-77F3-4454-8A66-7A795B42584E@objektpark.de>
From: =?ISO-8859-1?Q?Peter_Ro=DFbach?= <pr@objektpark.de>
To: "Tomcat Developers List" <dev@tomcat.apache.org>
In-Reply-To: <427155180905091903y54d05fdcj59ffc2d4b2a5d275@mail.gmail.com>
Content-Type: multipart/alternative; boundary=Apple-Mail-2--461226197
Mime-Version: 1.0 (Apple Message framework v930.3)
Subject: Re: svn commit: r772875 - /tomcat/tc6.0.x/trunk/STATUS.txt
Date: Sun, 10 May 2009 22:14:22 +0200
References: <20090508074828.D2FF02388A6E@eris.apache.org>
 <427155180905091903y54d05fdcj59ffc2d4b2a5d275@mail.gmail.com>

--Apple-Mail-2--461226197
Content-Type: text/plain;
	charset=US-ASCII;
	format=flowed;
	delsp=yes
Content-Transfer-Encoding: 7bit

OK,

I see the problem....

Peter

Am 10.05.2009 um 04:03 schrieb Konstantin Kolinko:

>> +
>> +* Fix Close Stream at WebappClassLoader after read error
>> +  http://svn.apache.org/viewvc?rev=772872&view=rev
>> +  +1: pero
>> +  -1:
>> +
>
> Nice catch, but what bugs me here
> (in WebappClassLoader#findResourceInternal)
> is the distance between opening the binaryStream and starting to use  
> it.
> There is a lot of processing, e.g.:
>  if (!openJARs()) {
>     return null;
>  }
>  if (antiJARLocking).
>
> I think that
> 1) the stream should be closed where it was before Peter's change
> (reverting rev.772872),
> but add setting binaryStream variable to null afterwards.
> 2) a global try/finally to be added around the whole method, closing  
> the
> stream in case of error or preliminary exit (e.g. caused by if (! 
> openJARs())).
>
> Best regards,
> Konstantin Kolinko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>


--Apple-Mail-2--461226197--