Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 68284 invoked from network); 6 May 2009 12:18:27 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 6 May 2009 12:18:27 -0000 Received: (qmail 70091 invoked by uid 500); 6 May 2009 12:18:26 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 70007 invoked by uid 500); 6 May 2009 12:18:26 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 69996 invoked by uid 99); 6 May 2009 12:18:25 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 May 2009 12:18:25 +0000 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [64.99.136.148] (HELO smtprelay-virgin.hostedemail.com) (64.99.136.148) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 May 2009 12:18:16 +0000 Received: from filter.hostedemail.com (ff-bigip1 [10.5.19.254]) by smtprelay06.hostedemail.com (Postfix) with SMTP id 41AF31774365 for ; Wed, 6 May 2009 12:17:54 +0000 (UTC) X-Spam-Summary: 2,0,0,3afe240045f4a7ae,eca4525d43bef93c,markt@apache.org,dev@tomcat.apache.org,RULES_HIT:152:355:379:599:601:854:945:973:988:989:1187:1260:1277:1311:1313:1314:1345:1358:1359:1437:1515:1516:1518:1534:1538:1567:1593:1594:1676:1711:1714:1730:1747:1766:1792:2393:2559:2562:3027:3866:3869:3872:3876:3877:4250:4321:4412:4605:5007:6114:6120:6261:7901:8501:8957,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fu,MSBL:none,DNSBL:none Received: from macbook.local (unknown [213.1.210.34]) (Authenticated sender: med.thomas) by omf10.hostedemail.com (Postfix) with ESMTP for ; Wed, 6 May 2009 12:17:53 +0000 (UTC) Message-ID: <4A017FF0.5070408@apache.org> Date: Wed, 06 May 2009 13:17:52 +0100 From: Mark Thomas User-Agent: Thunderbird 2.0.0.21 (Macintosh/20090302) MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r772142 - /tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java References: <20090506104904.18DC52388920@eris.apache.org> <1241608411.3322.2.camel@localhost.localdomain> In-Reply-To: <1241608411.3322.2.camel@localhost.localdomain> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-session-marker: 6D65642E74686F6D6173 X-Virus-Checked: Checked by ClamAV on apache.org Remy Maucherat wrote: > On Wed, 2009-05-06 at 10:49 +0000, markt@apache.org wrote: >> // Acquire global JNDI resources if available >> - Server server = ServerFactory.getServer(); >> + Server server = >> + ((Engine)context.getParent().getParent()).getService().getServer(); > > Ouch, not pretty. Any better ideas? I thought about pulling it out into a separate method but as all of those parents should be non-null it seemed like overkill. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org