Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 68014 invoked from network); 10 May 2009 03:55:02 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 10 May 2009 03:55:02 -0000 Received: (qmail 25794 invoked by uid 500); 10 May 2009 03:55:01 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 25703 invoked by uid 500); 10 May 2009 03:55:00 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 25692 invoked by uid 99); 10 May 2009 03:55:00 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 May 2009 03:55:00 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of knst.kolinko@gmail.com designates 209.85.218.177 as permitted sender) Received: from [209.85.218.177] (HELO mail-bw0-f177.google.com) (209.85.218.177) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 May 2009 03:54:52 +0000 Received: by bwz25 with SMTP id 25so2189546bwz.0 for ; Sat, 09 May 2009 20:54:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=tKIR1fLGkPRSawILYyQS+q9MiC+t2DS77eQoxBF/2+E=; b=jY7Gp5ri6J5WH7EXsLvjHQbnWLWeG0OItcvMxzSXawNMmD9Yl1sJYcS7XWenzH8bAb biSTiSLTzOR4l0snt+7zr+8gGnCxbueBLyqtJQPmrB0ubdE2Paq7Tnf2oWuPU2gyg5Fn 1PgN+EU3Y8X570LqqzRbjyi2z+Su0cB6sHnyY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=M/yOr50PgzVTrEzWWnWFcPDe30sWEM9LDZ7FWABtPcd6795xyyJTo4jtg8GSvn0XeX xUY8h0hvv3FeH6bTKQ6r6lp9UP1vHJTCaYbF6iBJ06Lc8oKtkxZfiCuP2gqTyXCN3zoH XLsaZLUF5luCuOF6ZBV+JsBLeh2AtBKfatdJQ= MIME-Version: 1.0 Received: by 10.103.222.1 with SMTP id z1mr3358026muq.121.1241927670926; Sat, 09 May 2009 20:54:30 -0700 (PDT) In-Reply-To: <4A017FF0.5070408@apache.org> References: <20090506104904.18DC52388920@eris.apache.org> <1241608411.3322.2.camel@localhost.localdomain> <4A017FF0.5070408@apache.org> Date: Sun, 10 May 2009 07:54:30 +0400 Message-ID: <427155180905092054hc69152fs8d4b36b1fa3bb423@mail.gmail.com> Subject: Re: svn commit: r772142 - /tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java From: Konstantin Kolinko To: Tomcat Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org 2009/5/6 Mark Thomas : > Remy Maucherat wrote: >> On Wed, 2009-05-06 at 10:49 +0000, markt@apache.org wrote: >>> =A0 =A0 =A0 =A0 =A0// Acquire global JNDI resources if available >>> - =A0 =A0 =A0 =A0Server server =3D ServerFactory.getServer(); >>> + =A0 =A0 =A0 =A0Server server =3D >>> + =A0 =A0 =A0 =A0 =A0 =A0((Engine)context.getParent().getParent()).getS= ervice().getServer(); >> >> Ouch, not pretty. > > Any better ideas? I thought about pulling it out into a separate method b= ut as > all of those parents should be non-null it seemed like overkill. > See how setWrapper() is already implemented in ManagerServlet. You can remember Engine reference that it calculates there, like host reference that is already remembered. Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org