From dev-return-95639-apmail-tomcat-dev-archive=tomcat.apache.org@tomcat.apache.org Tue May 05 10:42:50 2009 Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 79456 invoked from network); 5 May 2009 10:42:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 5 May 2009 10:42:49 -0000 Received: (qmail 27800 invoked by uid 500); 5 May 2009 10:42:48 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 27721 invoked by uid 500); 5 May 2009 10:42:47 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 27710 invoked by uid 99); 5 May 2009 10:42:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 May 2009 10:42:47 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 May 2009 10:42:45 +0000 Received: by brutus.apache.org (Postfix, from userid 33) id B8738234C041; Tue, 5 May 2009 03:37:24 -0700 (PDT) From: bugzilla@apache.org To: dev@tomcat.apache.org Subject: DO NOT REPLY [Bug 47124] Run the unit tests as part of the build!!! X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Tomcat 6 X-Bugzilla-Component: Catalina X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mguillemot@yahoo.fr X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dev@tomcat.apache.org X-Bugzilla-Target-Milestone: default X-Bugzilla-Changed-Fields: In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Message-Id: <20090505103724.B8738234C041@brutus.apache.org> Date: Tue, 5 May 2009 03:37:24 -0700 (PDT) X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/bugzilla/show_bug.cgi?id=47124 --- Comment #4 from Marc Guillemot 2009-05-05 03:37:21 PST --- (In reply to comment #3) >... > > This is is far less important that running the tests as part of the build, but > > I think that the tests should be renamed for consistency and as it just allows > > to use name patterns to select the tests (currently there is no convention > > here). In the current state of the test suite, I would prefer to select the > > tests by name pattern rather than having a TestAll as it doesn't have any > > advantage and this file needs to be modified each time a test is added (with > > the risk to have tests that aren't run). > That is a reasonable argument. Patches tend to get very large when renames are > concerned. A set of svn commands to run would be easier to review and to apply. Isn't it even more efficient if one committer (you?) just rename the files and commit the changes? > > > I don't understand either why you don't use Ant's junit task. > No idea. Merging the test.xml with the main build.xml and using Ant's junit > task would make sense. this was in the proposed patch. Should I upload an other one? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org