tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Ro├čbach ...@objektpark.de>
Subject Re: svn commit: r772875 - /tomcat/tc6.0.x/trunk/STATUS.txt
Date Sun, 10 May 2009 20:14:22 GMT
OK,

I see the problem....

Peter

Am 10.05.2009 um 04:03 schrieb Konstantin Kolinko:

>> +
>> +* Fix Close Stream at WebappClassLoader after read error
>> +  http://svn.apache.org/viewvc?rev=772872&view=rev
>> +  +1: pero
>> +  -1:
>> +
>
> Nice catch, but what bugs me here
> (in WebappClassLoader#findResourceInternal)
> is the distance between opening the binaryStream and starting to use  
> it.
> There is a lot of processing, e.g.:
>  if (!openJARs()) {
>     return null;
>  }
>  if (antiJARLocking).
>
> I think that
> 1) the stream should be closed where it was before Peter's change
> (reverting rev.772872),
> but add setting binaryStream variable to null afterwards.
> 2) a global try/finally to be added around the whole method, closing  
> the
> stream in case of error or preliminary exit (e.g. caused by if (! 
> openJARs())).
>
> Best regards,
> Konstantin Kolinko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message