tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r776390 - /tomcat/tc6.0.x/trunk/STATUS.txt
Date Fri, 22 May 2009 16:30:19 GMT
kkolinko@apache.org wrote:
> Author: kkolinko
> Date: Tue May 19 17:35:21 2009
> New Revision: 776390
> 
> URL: http://svn.apache.org/viewvc?rev=776390&view=rev
> Log:
> vote
> 
> Modified:
>     tomcat/tc6.0.x/trunk/STATUS.txt
> 
> Modified: tomcat/tc6.0.x/trunk/STATUS.txt
> URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=776390&r1=776389&r2=776390&view=diff
> ==============================================================================
> --- tomcat/tc6.0.x/trunk/STATUS.txt (original)
> +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue May 19 17:35:21 2009
> @@ -168,6 +168,18 @@
>    Deregister all MBeans when the server is stopped
>    http://svn.apache.org/viewvc?rev=769979&view=rev
>    +1: markt, pero
> +  +1: kkolinko (ok, but one question:
> +        in MBeanUtils.java:
> +
> +        @@ -1401,12 +1417,7 @@
> +         static void destroyMBean(Context context)
> +         ..
> +        +        String domain = context.getParent().getParent().getName();
> +                 if (domain == null)
> +                     domain = mserver.getDefaultDomain();
> +
> +         Can domain be null here,
Unlikely. We could probably ditch that test if we wanted to.

> or one of those getParent().foo() calls result in an NPE ?
No.

Mark

> +      )
>    -1: 
>  
>  * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47080
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message