tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r775792 - /tomcat/tc6.0.x/trunk/STATUS.txt
Date Fri, 22 May 2009 11:26:10 GMT
kkolinko@apache.org wrote:
> Modified: tomcat/tc6.0.x/trunk/STATUS.txt
> URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=775792&r1=775791&r2=775792&view=diff
> ==============================================================================
> --- tomcat/tc6.0.x/trunk/STATUS.txt (original)
> +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon May 18 02:15:04 2009
> @@ -55,6 +55,23 @@
>    http://svn.apache.org/viewvc?rev=746425&view=rev (to address Bill's concerns)
>    http://svn.apache.org/viewvc?rev=757335&view=rev (to remove the Catalina dep)
>    +1: markt, billbarker
> +  +1: kkolinko (good, but I have some concerns:
> +    r721286 : 
> +     You have added an anonymous inner class to JspFactoryImpl. That class is
> +     preloaded by o.a.jasper.security.SecurityClassLoad. I wonder, whether the
> +     new inner class should also be preloaded. Do not have experience to prove
> +     it, though.
I don't believe pre-loading is required in this case

> +     Plus, see issue #47214 in Bugzilla for my concerns on naming.
ACK

> +    r721704 :
> +     o.k.
> +     (I have concerns about DefaultInstanceManager (see issue #47214), but
> +     that class does not exist in TC 6.0)
ACK

> +    r746425:
> +     Implementation of ELResolverImpl.getDefaultResolver():
> +       All those "(CompositeELResolver)" casts can be removed if you change
> +       type of the local variable.
Fixed in trunk. I won't bother back-porting.

Cheers,

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message