tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: [VOTE] Release build 6.0.20
Date Mon, 25 May 2009 14:55:46 GMT
2009/5/24 sebb <sebbaz@gmail.com>:
> On 24/05/2009, Konstantin Kolinko <knst.kolinko@gmail.com> wrote:
>> 2009/5/14 Remy Maucherat <remm@apache.org>:
>>
>> > The candidates binaries are available here:
>>  > http://people.apache.org/~remm/tomcat-6/v6.0.20/
>>  >
>>  > According to the release process, the 6.0.20 tag is:
>>  > [ ] Broken
>>  > [ ] Alpha
>>  > [ ] Beta
>>
>> > [x] Stable
>>  >
>>
>>  I do not see any issues with the release, except the one
>>  of the tgz sources archive.
>>
>>  Regarding the tgz archive of the sources I propose the following:
>>  The build was created on an Unix machine, so the files in the zip
>>  archive are good enough to rerun the build on unixes.
>>
>>  Thus, it is sufficient to repack the archive as tgz.
>
> Strictly speaking, it's not sufficient, because the binary archives
> are supposed to be derivable from the source archives.
>

It is source archive (-src.tar.gz) I am talking about.  All binaries
are derivable from it.

I do not see a contradiction here.

It contains the same files as -src.zip. I used Apache Ant 1.7.0 to repack these
sources (using the package-src-tgz target from dist.xml, but with fxcrlf filter
removed).


> See
> http://www.apache.org/dev/release.html#what
>
> at the end of the section it says:
>
> "In all such cases, the binary/bytecode package must have the same
> version number as the source release and may only add binary/bytecode
> files that are the result of compiling that version of the source code
> release."
>
> This is not the case for the tgz archive.
>
>>  I prepared such
>>  an archive and placed it in
>>  http://people.apache.org/~kkolinko/tomcat-6/v6.0.20/src/
>>
>>  md5 sum is
>>  6a747d5bfa6b0b57605e8697ca8a4cae *apache-tomcat-6.0.20-src.tar.gz
>>

There are also the following options:

1. Rerun the build, but now with
LANG=en_US.ISO8859-1; export LANG;
before it.

It will fix the UTF-8 issue with -src.tar.gz

2. Release as is. As Mark noted, 6.0.18 suffers from the same issue.

I am OK with it.



Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message