tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Mutable public fields in Tomcat 6 code
Date Thu, 21 May 2009 22:09:02 GMT
There are quite a lot of public mutable static fields in the current
Tomcat6 codebase.

Such fields can allow malicious or accidental changes to occur, so
should be avoided as far as possible.
[And if a class has public mutable static fields it's generally
impossible to make it thread-safe.]

The code also has quite a lot of public mutable instance fields, which
are almost as bad.

Is there any interest in fixing these?
If so, I can create patches for many of them.
Some classes might need redesigning.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message